Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comet HPO #563

Merged
merged 19 commits into from
Sep 26, 2022
Merged

Comet HPO #563

merged 19 commits into from
Sep 26, 2022

Conversation

sherpan
Copy link
Contributor

@sherpan sherpan commented Sep 16, 2022

Description

Added Comet's Optimizer as an HPO option

  • Fixes # (issue)
    Rendering of some screenshots in the doc

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which refactors the code base)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

ashwinvaidya17
ashwinvaidya17 reviewed Sep 19, 2022
View reviewed changes
Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this is a great addition. I have two minor comments.

tools/hpo/comet_sweep.yaml Outdated Show resolved Hide resolved
docs/source/guides/hyperparameter_optimization.rst Outdated Show resolved Hide resolved
@ashwinvaidya17 ashwinvaidya17 mentioned this pull request Sep 19, 2022
Closed
@sherpan
Copy link
Contributor Author

sherpan commented Sep 23, 2022

sorry for the delay in addressing the comments. but all issues should be addressed

@sherpan sherpan closed this Sep 23, 2022
@sherpan sherpan reopened this Sep 23, 2022
ashwinvaidya17
ashwinvaidya17 approved these changes Sep 26, 2022
View reviewed changes
Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. There is a minor codacy issue here but we can fix that after merge.

samet-akcay
samet-akcay approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sherpan for the effort!

@samet-akcay samet-akcay merged commit 353d981 into openvinotoolkit:main Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samet-akcay samet-akcay samet-akcay approved these changes

@ashwinvaidya17 ashwinvaidya17 ashwinvaidya17 approved these changes

Assignees
No one assigned
Labels
HPO Tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sherpan @ashwinvaidya17 @samet-akcay